Skip to content

minimal Pg 14beta1 - update #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ImreSamu wants to merge 2 commits into from
Closed

minimal Pg 14beta1 - update #848

ImreSamu wants to merge 2 commits into from

Conversation

@ImreSamu
Copy link
Contributor

@ImreSamu ImreSamu commented May 24, 2021

as I see:

"PostgreSQL 14 Beta 1 Released!" ( 2021-05-20 )
https://www.postgresql.org/about/news/postgresql-14-beta-1-released-2213/

this is a minimal test - for adding
IMHO: the next debian version ( "bullseye" ) selected. ( for a postgis dockerimage - it has a newer geos version )

casio
casio reviewed May 27, 2021
View reviewed changes
14/Dockerfile Outdated
VOLUME /var/lib/postgresql/data

COPY docker-entrypoint.sh /usr/local/bin/
RUN ln -s usr/local/bin/docker-entrypoint.sh / # backwards compat
Copy link

@casio casio May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lil typo?

Suggested change
RUN ln -s usr/local/bin/docker-entrypoint.sh / # backwards compat
RUN ln -s /usr/local/bin/docker-entrypoint.sh / # backwards compat

Copy link
Member

@tianon tianon May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like update.sh wasn't run:

postgres/update.sh

Lines 159 to 161 in 376f87c

if [ "$majorVersion" -gt 11 ]; then
sed -i '/backwards compat/d' "$version/$variant/Dockerfile"
fi

@tianon
Copy link
Member

tianon commented May 27, 2021

Do we have any idea what the GA timeline for 14 is going to be? I'm not sure when Bullseye will GA, but we don't want to jump the gun too much there.

@ImreSamu
Copy link
Contributor Author

ImreSamu commented May 27, 2021

Do we have any idea what the GA timeline for 14 is going to be?

2021Q3?
"The next major release of PostgreSQL is planned to be the 14 release. A tentative schedule for this version has a release in the third quarter of 2021." https://www.postgresql.org/developer/roadmap/

I'm not sure when Bullseye will GA,

OK; Let's go now with "buster" .. and change later to "bullseye"

( You can adapt|remove|drop my PR .. as you like 😄 )

@ImreSamu @yosifkit
add pg14 generated files created by the new ./update.sh
fd3e127 
drop 9.5 since it was EOL in February
@ImreSamu
Copy link
Contributor Author

ImreSamu commented May 27, 2021

Thanks for the fix!

ouch .. as I see the PG14 (alpine) has new feature options

--with-lz4
"Build with LZ4 compression support. This allows the use of LZ4 for compression of table data."
( https://www.postgresql.org/docs/14/install-procedure.html )

probably important for the new "LZ4 compression for TOAST"

@yosifkit yosifkit mentioned this pull request Jul 9, 2021
Merged
@tianon tianon closed this in #865 Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon left review comments

+1 more reviewer

@casio casio casio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ImreSamu @tianon @casio